add option to pick build args from env#92
Open
bhaskar2509 wants to merge 1 commit intoGetSimpl:masterfrom
Open
add option to pick build args from env#92bhaskar2509 wants to merge 1 commit intoGetSimpl:masterfrom
bhaskar2509 wants to merge 1 commit intoGetSimpl:masterfrom
Conversation
|
One downside of taking env vars in build is that, images become environment specific without someone intending. This way someone will deploy master to staging or vice versa. But there are some genuine cases like this one where it is unavoidable. We should figure out a way but opaquely passing env variables is not one. |
Contributor
|
@bhaskar-simpl Please update the readme with an example of how this is to be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.